Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXT-280 - EXT-280-open-project-vcs #744

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Conversation

corinnesollows
Copy link
Contributor

@corinnesollows corinnesollows commented Jun 30, 2022

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

  • Added a warning in the error for Open command that only Github and Bitbucket are supported at this time
  • Further commenting and formatting on the open.go file

Rationale

We are no longer supporting the 'open' command going forward, but we do not wish to remove the legacy functionality

Screenshots

Screen Shot 2022-06-30 at 2 51 35 PM

JIRA Ticket

@corinnesollows corinnesollows requested a review from a team as a code owner June 30, 2022 17:57
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the added comments! LGTM

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #744 (8acd023) into master (859abf9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   31.81%   31.79%   -0.02%     
==========================================
  Files          44       44              
  Lines        5322     5324       +2     
==========================================
  Hits         1693     1693              
- Misses       3379     3381       +2     
  Partials      250      250              
Impacted Files Coverage Δ
cmd/open.go 50.00% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859abf9...8acd023. Read the comment docs.

@corinnesollows corinnesollows merged commit f3c1720 into master Jul 4, 2022
@corinnesollows corinnesollows deleted the EXT-280-open-project-vcs branch July 4, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants