Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECENG-669] Remove 'active' attribute for policies #750

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

sagar-connect
Copy link
Contributor

@sagar-connect sagar-connect commented Jul 13, 2022

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Changes

=======

  • Remove 'active' attribute for policies in source (both cmd/api)
  • Updated unit-tests
  • Updated expected-data.txt (golden tests data)

Rationale

=========
This is in continuation to https://github.com/circleci/policy-service/pull/146

@sagar-connect sagar-connect requested a review from a team as a code owner July 13, 2022 20:32
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #750 (e9a09d3) into master (830e7ff) will increase coverage by 0.03%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   31.75%   31.79%   +0.03%     
==========================================
  Files          44       44              
  Lines        5331     5316      -15     
==========================================
- Hits         1693     1690       -3     
+ Misses       3388     3382       -6     
+ Partials      250      244       -6     
Impacted Files Coverage Δ
api/policy/policy.go 65.45% <40.00%> (+1.54%) ⬆️
cmd/policy/policy.go 81.94% <100.00%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830e7ff...e9a09d3. Read the comment docs.

@sagar-connect sagar-connect merged commit e15f916 into master Jul 13, 2022
@sagar-connect sagar-connect deleted the SECENG-669-remove-active-flag-from-policies branch July 13, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants