Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate parameters to with_cache correctly #13

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Propagate parameters to with_cache correctly #13

merged 2 commits into from
Apr 20, 2022

Conversation

skjolber
Copy link
Contributor

@skjolber skjolber commented Apr 20, 2022 •
edited
Loading

For some reason the linter did not catch this. See with_cache in the maven orb for reference.

See #11

@skjolber
Copy link
Contributor Author

@Jaryt @KyleTryon

@Jaryt Jaryt self-requested a review April 20, 2022 19:50
@Jaryt
Copy link
Contributor

Jaryt commented Apr 20, 2022

Good find @skjolber! Thank you for the fix. Going to run the tests for this now 👍

@Jaryt Jaryt merged commit 2e5aa0f into CircleCI-Public:master Apr 20, 2022
@skjolber
Copy link
Contributor Author

Thanks @Jaryt! 🚀

@skjolber
Copy link
Contributor Author

skjolber commented Apr 21, 2022 •
edited
Loading

@Jaryt seems your build is broken though

@Jaryt Jaryt mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Awaiting requested review from Jaryt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjolber @Jaryt