Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/app 390 fix runtime errors #374

Merged
merged 11 commits into from
Jul 27, 2023
Merged

Conversation

ingoCollatz
Copy link
Contributor

No description provided.

shell/src/shared/openLogin.ts Outdated Show resolved Hide resolved
shell/src/shared/processes/shellProcess.ts Outdated Show resolved Hide resolved
shell/src/main.ts Outdated Show resolved Hide resolved
@ingoCollatz ingoCollatz requested a review from codeho July 27, 2023 07:32
Copy link
Contributor

@jaensen jaensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one remark:
In one case you used

import { get } from 'svelte/store'

and then

      const $me = get(me)

in the other case you left

    let $me: Profile;
    me.subscribe((m) => ($me = m))();

which in principle is fine. But using the get() shorthand everywhere would surely have been nicer (I know, the latter was by me 😂).

@ingoCollatz ingoCollatz merged commit 96227eb into dev Jul 27, 2023
1 check passed
@ingoCollatz ingoCollatz deleted the feature/app-390-fix-runtime-errors branch July 27, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants