Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart: Migrate to null safety #99

Closed
26 tasks done
manjotsidhu opened this issue Jun 12, 2021 · 10 comments · Fixed by #182
Closed
26 tasks done

Dart: Migrate to null safety #99

manjotsidhu opened this issue Jun 12, 2021 · 10 comments · Fixed by #182
Labels

Comments

@manjotsidhu
Copy link
Member

manjotsidhu commented Jun 12, 2021

Describe the bug
We should be migrating to null safety which was introduced in Dart 2.0. But before that, we need to make sure that first our dependencies are migrated to null safety according to this Guide: https://dart.dev/null-safety/migration-guide

Wait for the packages that you depend on to migrate.
Migrate your package’s code, preferably using the interactive migration tool.
Statically analyze your package’s code.
Test to make sure your changes work.
If the package is already on pub.dev, publish the null-safe version as a prerelease version.

This Issue serves as a checklist of all the packages which have been migrated to null safety.

  • animations
  • cupertino_icons
  • datetime_picker_formfield
  • flutter_facebook_auth
  • flutter_html
  • [Null Safety] swap flutter_icons with fluttericon #119
  • flutter_keyboard_visibility
  • flutter_summernote (published on 21st June)
  • flutter_svg
  • flutter_typeahead
  • get
  • get_it
  • google_sign_in
  • html
  • http
  • intl
  • mockito
  • oauth2_client
  • photo_view
  • provider
  • share
  • shared_preferences
  • theme_provider
  • timeago
  • transparent_image
  • url_launcher

Once this list is complete which means all our packages are sound null safety. We should use migration tool to migrate to null safety.

@manjotsidhu
Copy link
Member Author

@Nitish145 flutter_icons is not maintained anymore, can we switch to fluttericon:https://pub.dev/packages/fluttericon ?

@Nitish145
Copy link
Member

Go Ahead @manjotsidhu

@manjotsidhu
Copy link
Member Author

@Nitish145 flutter_icons is not maintained anymore, can we switch to fluttericon:https://pub.dev/packages/fluttericon ?

@ShreyaPrasad1209 this can also be considered as #good-first-issue.

@ShreyaPrasad1209 ShreyaPrasad1209 added the good first issue Good for newcomers label Jun 13, 2021
@manjotsidhu manjotsidhu pinned this issue Jul 10, 2021
@Mobasherah12
Copy link

@manjotsidhu @ShreyaPrasad1209 Hi, I'm an Open Source Day participant, willing to work on this. Please do assign me.

@manjotsidhu
Copy link
Member Author

@manjotsidhu @ShreyaPrasad1209 Hi, I'm an Open Source Day participant, willing to work on this. Please do assign me.

Go ahead!

@prasadsunny1
Copy link

What more needs to be done in this issue?

@manjotsidhu
Copy link
Member Author

What more needs to be done in this issue?

https://dart.dev/null-safety/migration-guide

@prasadsunny1
Copy link

Let me try migrating

@prasadsunny1
Copy link

#156
I have started working but am stuck at some errors in migrating testcases

@aman-singh7
Copy link
Member

@manjotsidhu can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants