-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to null safety #182
Conversation
@aman-singh7 in CI/CD build step you can remove https://github.com/CircuitVerse/mobile-app/blob/master/.github/workflows/ci.yml#L31 |
a48a9ad
to
0b89949
Compare
@manjotsidhu migration is done. I am currently refactoring the test. Could you test the app when available and do let me know any issues? |
@aman-singh7 the changes are working fine. Will review the code soon. |
@manjotsidhu The CI is failing due to the IOS build. Can you update the Podfile as I don't have Mac? |
@aman-singh7 I will update the pods soon |
* The null safe flutter_facebook_auth uses min ios 10.0 version Signed-off-by: Manjot Sidhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aman-singh7 for your valuable contributions here.
Fixes #99
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.