Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null safety #182

Merged
merged 20 commits into from
Jan 14, 2022
Merged

Conversation

aman-singh7
Copy link
Member

Fixes #99

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@manjotsidhu
Copy link
Member

manjotsidhu commented Dec 28, 2021

@aman-singh7 in CI/CD build step you can remove --no-sound-null-safety

https://github.com/CircuitVerse/mobile-app/blob/master/.github/workflows/ci.yml#L31

@aman-singh7 aman-singh7 changed the title [WIP]: Migrate to null safety Migrate to null safety Jan 3, 2022
@aman-singh7
Copy link
Member Author

@manjotsidhu migration is done. I am currently refactoring the test. Could you test the app when available and do let me know any issues?

@aman-singh7 aman-singh7 marked this pull request as ready for review January 3, 2022 08:40
@manjotsidhu
Copy link
Member

@aman-singh7 the changes are working fine. Will review the code soon.

@aman-singh7
Copy link
Member Author

@manjotsidhu The CI is failing due to the IOS build. Can you update the Podfile as I don't have Mac?

@manjotsidhu
Copy link
Member

@aman-singh7 I will update the pods soon

* The null safe flutter_facebook_auth uses min ios 10.0 version

Signed-off-by: Manjot Sidhu <[email protected]>
@coveralls
Copy link

coveralls commented Jan 14, 2022

Pull Request Test Coverage Report for Build 1696831596

  • 448 of 617 (72.61%) changed or added relevant lines in 104 files are covered.
  • 31 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.4%) to 71.894%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/cv_theme.dart 1 2 50.0%
lib/services/API/ib_api.dart 2 3 66.67%
lib/ui/components/cv_add_icon_button.dart 0 1 0.0%
lib/ui/components/cv_flat_button.dart 0 1 0.0%
lib/ui/views/base_view.dart 1 2 50.0%
lib/ui/views/groups/my_groups_view.dart 4 5 80.0%
lib/ui/views/groups/update_assignment_view.dart 8 9 88.89%
lib/ui/views/ib/builders/ib_pop_quiz_builder.dart 1 2 50.0%
lib/ui/views/ib/builders/ib_subscript_builder.dart 0 1 0.0%
lib/ui/views/ib/builders/ib_superscript_builder.dart 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
lib/models/dialog_models.dart 1 50.0%
lib/services/dialog_service.dart 1 0%
lib/ui/views/contributors/components/contributors_donate_card.dart 1 84.21%
lib/ui/views/contributors/components/contributors_support_card.dart 1 94.44%
lib/ui/views/home/components/feature_card.dart 1 93.33%
lib/ui/views/ib/ib_landing_view.dart 1 66.67%
lib/ui/views/ib/ib_page_view.dart 1 58.77%
lib/ui/views/teachers/components/teachers_card.dart 1 94.74%
lib/models/assignments.dart 2 95.45%
lib/ui/views/ib/components/ib_pop_quiz_button.dart 2 0%
Totals Coverage Status
Change from base Build 1645684340: -0.4%
Covered Lines: 3860
Relevant Lines: 5369

💛 - Coveralls

Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YesSirSaluteGIF

Copy link
Member

@Nitish145 Nitish145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aman-singh7 for your valuable contributions here.

@manjotsidhu manjotsidhu merged commit 99793de into CircuitVerse:master Jan 14, 2022
@aman-singh7 aman-singh7 deleted the null_safety branch March 3, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart: Migrate to null safety
4 participants