Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lints): single quote and const constructor rules #150

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

manjotsidhu
Copy link
Member

@manjotsidhu manjotsidhu commented Oct 6, 2021

Ref: #149

Fix lints for these rules:

  • prefer_single_quotes (already incorporated)
  • prefer_const_constructors

@manjotsidhu
Copy link
Member Author

@Neha62-lit can you review this ?

@Neha62-lit
Copy link
Contributor

@Neha62-lit can you review this ?

Yes

@Neha62-lit
Copy link
Contributor

@manjotsidhu Now can I fix rest of the all linting rules?

@manjotsidhu
Copy link
Member Author

@manjotsidhu Now can I fix rest of the all linting rules?

Yes, just let me merge this.

Fix lint rules for these rules:
* prefer_single_quotes
* prefer_const_constructors

Signed-off-by: Manjot Sidhu <[email protected]>
@Neha62-lit
Copy link
Contributor

@manjotsidhu Now can I fix rest of the all linting rules?

Yes, just let me merge this.

Okay

@manjotsidhu
Copy link
Member Author

@tachyons kindly review this.

@manjotsidhu manjotsidhu merged commit d0305c2 into master Oct 6, 2021
@manjotsidhu manjotsidhu deleted the fix-lints-1 branch October 6, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants