Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lints): avoid_unnecessary_containers rule #152

Merged
merged 3 commits into from
Oct 8, 2021
Merged

fix(lints): avoid_unnecessary_containers rule #152

merged 3 commits into from
Oct 8, 2021

Conversation

Neha62-lit
Copy link
Contributor

Fixes #149

Fix lints for these rule:

  • avoid_unnecessary_containers
  • avoid_print

@Neha62-lit
Copy link
Contributor Author

@manjotsidhu review this PR!

manjotsidhu
manjotsidhu reviewed Oct 7, 2021
View reviewed changes
analysis_options.yaml Outdated Show resolved Hide resolved
manjotsidhu
manjotsidhu reviewed Oct 7, 2021
View reviewed changes
analysis_options.yaml Outdated Show resolved Hide resolved
@Neha62-lit
Copy link
Contributor Author

Hey @manjotsidhu, Review this PR!

@manjotsidhu
Copy link
Member

Have you confirmed that removing Container gives no changes to the UI ?

@Neha62-lit
Copy link
Contributor Author

Have you confirmed that removing Container gives no changes to the UI ?

Yes, there is no changes in UI.

@manjotsidhu manjotsidhu merged commit 5849c2e into CircuitVerse:master Oct 8, 2021
@Neha62-lit Neha62-lit deleted the fix-lints-2 branch October 8, 2021 05:56
@manjotsidhu manjotsidhu mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjotsidhu manjotsidhu manjotsidhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and enable linter rules
2 participants
@Neha62-lit @manjotsidhu