Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lints): prefer_typing_uninitialized_variables rule #161

Merged
merged 3 commits into from
Oct 15, 2021

Conversation

Neha62-lit
Copy link
Contributor

Refer #149

Fix lint rule:

  • prefer_typing_uninitialized_variables
  • Clean the analysis_options.yaml file

@Neha62-lit
Copy link
Contributor Author

Hey @manjotsidhu,
In app_exceptions.dart file, I didn't get it how to apply prefer_typing_uninitialized_variables rule so I ignore that rule as of now. Can you tell me how can we apply rule in that file?

@@ -1,5 +1,7 @@
class AppException implements Exception {
// ignore: prefer_typing_uninitialized_variables
final _message;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can specify it's datatype

Suggested change
final _message;
final String _message;

@coveralls
Copy link

coveralls commented Oct 15, 2021

Pull Request Test Coverage Report for Build 1345795607

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.555%

Totals Coverage Status
Change from base Build 1344866083: 0.0%
Covered Lines: 3855
Relevant Lines: 5241

💛 - Coveralls

@manjotsidhu manjotsidhu merged commit 83ed9af into CircuitVerse:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants