Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lints): multiple linter rules #149 #179

Merged
merged 3 commits into from
Dec 24, 2021

Conversation

Aadeesh11
Copy link
Contributor

@Aadeesh11 Aadeesh11 commented Dec 15, 2021

Ref #149.

Describe the changes you have made in this PR -
Enabled linter:

  1. unnecessary_parenthesis
  2. avoid_redundant_argument_values

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@Aadeesh11
Copy link
Contributor Author

@manjotsidhu my local tests are passing, any idea why CI tests are failing?

@manjotsidhu
Copy link
Member

@manjotsidhu my local tests are passing, any idea why CI tests are failing?

Apologies for late reply, thanks for your contribution. CI Tests use flutter 2.8 to build and test so please wait until we resolve this.

@manjotsidhu
Copy link
Member

@manjotsidhu my local tests are passing, any idea why CI tests are failing?

You can rebase your changes and CI will pass now

@coveralls
Copy link

coveralls commented Dec 24, 2021

Pull Request Test Coverage Report for Build 1618864256

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • 178 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-1.2%) to 72.302%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/groups/add_assignment_view.dart 0 1 0.0%
lib/ui/views/groups/update_assignment_view.dart 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
lib/utils/router.dart 4 57.14%
lib/viewmodels/ib/ib_page_viewmodel.dart 12 53.85%
lib/services/local_storage_service.dart 20 23.26%
lib/viewmodels/ib/ib_landing_viewmodel.dart 32 17.95%
lib/ui/views/ib/ib_landing_view.dart 48 66.21%
lib/ui/views/ib/ib_page_view.dart 62 59.05%
Totals Coverage Status
Change from base Build 1540966382: -1.2%
Covered Lines: 3879
Relevant Lines: 5365

💛 - Coveralls

@manjotsidhu manjotsidhu merged commit ba90d7a into CircuitVerse:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants