fix(favorites): updated starred state is not reflecting #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manjotsidhu are these changes working as expected? |
… to previous screen
aman-singh7
force-pushed
the
bfix_starred_state
branch
from
add1f2a
to
a452b16
Compare
Pull Request Test Coverage Report for Build 1866700109
💛 - Coveralls |
|
@manjotsidhu Have you tested the changes? 😅 |
Yes, just now. The changes are not working as expected. There are some issues. I will share it with you shortly |
Screenrecorder-2022-02-18-18-44-04-785.mp4 |
Screenrecorder-2022-02-18-20-04-56-66.mp4@manjotsidhu fixed it. Could you please test now? |
manjotsidhu
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
Describe the changes you have made in this PR - The changed of state of starred is not reflected after the screen is popped. For example, in featured circuits if user starred a project then move back and again returning to that project still shows the previous state i.e. unstarred and similar thing in profile favorites section, if user unstarred the project then it is not removed from there.
Screenshots of the changes (If any) -
Screenrecorder-2022-02-04-01-31-20-963.mp4
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.