Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the Android embedding v2 #201

Merged
merged 3 commits into from
Feb 13, 2022

Conversation

aman-singh7
Copy link
Member

Fixes #200

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

pubspec.yaml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 11, 2022

Pull Request Test Coverage Report for Build 1831582213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 88 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.2%) to 70.74%

Files with Coverage Reduction New Missed Lines %
lib/data/restriction_elements.dart 8 0%
lib/utils/unicode_map.dart 80 0%
Totals Coverage Status
Change from base Build 1776677457: -1.2%
Covered Lines: 3861
Relevant Lines: 5458

💛 - Coveralls

@Nitish145
Copy link
Member

@aman-singh7 Can you break this PR into two of which the first handle the flutter 2.10.0's Looking up a deactivated widget's ancestor is unsafe error for photo_view. Then this one actually is Migrating to Android embedding v2.

@aman-singh7
Copy link
Member Author

ok @Nitish145 👍

@aman-singh7
Copy link
Member Author

@Nitish145 Done. Tests will pass only when both of them are merged. 😅

@Nitish145
Copy link
Member

@aman-singh7 Please rebase this PR, so that only Android embedding v2 changes are the ones that build this PR.

@Nitish145 Nitish145 merged commit daa6649 into CircuitVerse:master Feb 13, 2022
@aman-singh7 aman-singh7 deleted the migration branch March 3, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate App to Android Embedding v2
3 participants