-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Button to Open Circuit Link in Browser #271
Conversation
onPressed: () async { | ||
final url = Uri.parse( | ||
'https://circuitverse.org/users/${widget.project.relationships.author.data.id}/projects/${widget.project.id}'); | ||
await launchUrl(url, mode: LaunchMode.externalApplication); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already an predefined function for launchUrl in lib/utils/url_launcher.dart, kindly use that function to open the link and do require changes if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have changed the code accordingly , please review the code.
@vedant-jain03 it's ready to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tanmoy741127 @sainideepanshu199 Here as well launchURL function could be used in alot of places, we should not be causing effects in other parts of the apps. |
ok ! |
await launchUrlString(url); | ||
await launchUrlString(url, mode: LaunchMode.externalApplication); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default , keep it launchUrlString(url) without mode: LaunchMode.externalApplication
Pass an varibale in function openInExternalApplication
with default value False
Do the necessary changes, in the mode: LaunchMode.externalApplication
also.
Pull Request Test Coverage Report for Build 4329758659
💛 - Coveralls |
can anyone tell the status of this pr, does it has errors or is it not reviewed till now. |
Fixes #261
Describe the changes you have made in this PR -
added button that opens the circuit link in device default browser
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.