Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'None' text to show when user has no groups #66

Closed
wants to merge 3 commits into from

Conversation

CoderMayhem
Copy link

Fixes #
Improving UX.

Describe the changes you have made in this PR -
Adding a text widget showing 'None' when the user is not a member of any group. Improves UX.

Screenshots of the changes (If any) -
Before :
before
After:
after

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@manjotsidhu
Copy link
Member

Instead of "None", it would be better if we give a informative message. For example, For Groups You're in, "You are currently not in any groups, create or join a group to get started".

@CoderMayhem
Copy link
Author

Instead of "None", it would be better if we give a informative message. For example, For Groups You're in, "You are currently not in any groups, create or join a group to get started".

Won't it look a bit redundant and repetitive having the same message(you are currently not in any groups....) shown under both the Groups You Mentor and Groups You're In headings when we have given a Make New Group button just above it?

I guess we can remove the headings altogether and just display a single "You're not in any groups..." message in this case. Something like this :
group1
Let me know your thoughts.

@manjotsidhu
Copy link
Member

Instead of "None", it would be better if we give a informative message. For example, For Groups You're in, "You are currently not in any groups, create or join a group to get started".

Won't it look a bit redundant and repetitive having the same message(you are currently not in any groups....) shown under both the Groups You Mentor and Groups You're In headings when we have given a Make New Group button just above it?

I guess we can remove the headings altogether and just display a single "You're not in any groups..." message in this case. Something like this :
group1
Let me know your thoughts.

I was just pointing out example for "Groups your In". I wanted your to decide the informative messages rather than just keeping just "None". Also, it's better to have both Mentored Groups and Joined Groups separate. It helps teachers/others to moderate.

@CoderMayhem
Copy link
Author

Does this look fine??
group2

@Nitish145
Copy link
Member

Does this look fine??
group2

Better! Also, get some views in the #ux channel.

@Nitish145 Nitish145 linked an issue Feb 7, 2021 that may be closed by this pull request
@nitin10s
Copy link
Member

It would be better if we could add a small illustration to this as well. also remove the grey bg, it looks odd

@RakeshSeervi
Copy link
Contributor

RakeshSeervi commented May 20, 2021

we can move the option Make new group under the section Groups you mentor

and then we have a choice

we can display the two sections in a way similar to how we display projects created by the user and the ones starred by the user

OR

we can avoid the heading Groups you're in when there are no such groups because the user anyways cannot join an existing group.

@manjotsidhu
Copy link
Member

Since the PR is now stale and due to new changes, I am closing this PR. Feel free to open another one anytime :)
Thanks for Contributing 👍

@manjotsidhu manjotsidhu closed this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No text shown when the user isn't a member of any group
5 participants