Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes needed for 2.6.1, also new data sources and tests #83

Merged
merged 1 commit into from
Dec 29, 2023
Merged

changes needed for 2.6.1, also new data sources and tests #83

merged 1 commit into from
Dec 29, 2023

Conversation

rschmied
Copy link
Member

@rschmied rschmied commented Dec 28, 2023 •
edited
Loading

Version 0.7.0

  • added support for "hide links" node resource property, fixes Add an option on cml2_node to hide it #80
  • added external connector data source
  • fixed integration test for groups data source
  • return error for external connector configuration when device name is provided instead of "NAT" or "System Bridge", fixes Error: Provider produced inconsistent result after apply #81
  • updated all package dependencies
  • fix CPULimit property for UMS and ExtConn (they are now always NULL starting with 2.6.0)
  • some cosmetic and test changes
  • added a add-to-booted-lab lifecycle test (addresses On updating a lab with more nodes, the lab needs to be destroyed first #75 but can't reproduce)
  • formatted codebase w/ gofumpt
  • removed cmlclient go.mod local replace and updated cmlclient to 0.0.22 in go.mod
  • added / updated docs and ran generate
  • bumped go version to 1.21 in the workflows
  • added an extconn schema test
  • updated gh action components, only run one test suite in parallel

@coveralls
Copy link

coveralls commented Dec 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7351501436

  • 217 of 235 (92.34%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 87.933%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/create.go 10 18 55.56%
internal/provider/datasource/extconn/extconn.go 78 88 88.64%
Totals Coverage Status
Change from base Build 5002716377: 0.2%
Covered Lines: 3046
Relevant Lines: 3464
💛 - Coveralls

@rschmied rschmied self-assigned this Dec 28, 2023
@rschmied rschmied force-pushed the 26version branch 3 times, most recently from 61bbe54 to 7b9564b Compare December 28, 2023 21:20
@rschmied
Version 0.7.0 update
327dfac 
- added support for "hide links" node resource property, fixes #80
- added external connector data source
- fixed integration test for groups data source
- return error for external connector configuration when device name
  is provided instead of "NAT" or "System Bridge", fixes #81
- updated all package dependencies
- fix CPULimit property for UMS and ExtConn (they are now always NULL
  starting with 2.6.0)
- some cosmetic and test changes
- added a add-to-booted-lab lifecycle test
- formatted codebase w/ gofumpt
- removed cmlclient go.mod local replace and updated cmlclient to 0.0.22 in go.mod
- added / updated docs and ran generate
- bumped go version to 1.21 in the workflows
- added an extconn schema test
- updated gh action components, only run one test suite in parallel
@rschmied rschmied merged commit e1d81ee into main Dec 29, 2023
6 checks passed
@rschmied rschmied deleted the 26version branch December 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rschmied rschmied

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Provider produced inconsistent result after apply Add an option on cml2_node to hide it
2 participants
@rschmied @coveralls