Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#142 cml nodes slow #144

Merged
merged 12 commits into from
Oct 31, 2023
Merged

#142 cml nodes slow #144

merged 12 commits into from
Oct 31, 2023

Conversation

xorrkaz
Copy link
Collaborator

@xorrkaz xorrkaz commented Oct 31, 2023

Do not refresh operational data for each node. Do this once, and then use the cache.

@jclarke-csco
Bump version to 1.4.3.
24369a8
@jclarke-csco
Proposed fix for #142.
2fc2ce1 
Skip an operational sync per node, but do all other syncs.  The
operational sync seems to take quite a long time.  This is definitely
more code than is required, but it only relies on public methods and
properties and skips any magic constants.
@jclarke-csco
Spell the l3 method correctly.
7965ee2
@jclarke-csco
Potentially use the cache for operational.
1156056
@jclarke-csco
Call node.compute_id as little as possible.
2d39012 
Submitted by:	sgherdao
@jclarke-csco
Protect against earlier versions of the client library.
071a213
@jclarke-csco
Protect getattr.
098229e
@jclarke-csco
We don't need to sync stats as we don't use it.
c6efa31
@jclarke-csco
Optimize conditional.
2f203dd 
Submitted by:	sgherdao
@jclarke-csco
Only call booted() once.
cc96962
@jclarke-csco
More micro optimizations to avoid API roundtrips.
0dc4a99
@jclarke-csco
Remove a bit that snuck into the last commit.
7e93a41
@coveralls
Copy link

coveralls commented Oct 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6704449112

  • 27 of 32 (84.38%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 73.196%
Changes Missing Coverage Covered Lines Changed/Added Lines %
virl/cli/views/nodes/node_views.py 23 28 82.14%
Files with Coverage Reduction New Missed Lines %
virl/api/plugin.py 1 90.82%
virl/cli/views/nodes/node_views.py 1 81.82%
Totals Coverage Status
Change from base Build 6484230927: 0.01%
Covered Lines: 2455
Relevant Lines: 3354
💛 - Coveralls

@xorrkaz xorrkaz changed the base branch from master to joe-dev October 31, 2023 09:24
@xorrkaz xorrkaz merged commit e078d21 into joe-dev Oct 31, 2023
12 checks passed
@xorrkaz xorrkaz deleted the 142-cml-nodes-slow branch October 31, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xorrkaz @coveralls @jclarke-csco