Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(152): cml ls --all-users display wrong owner #153

Closed

Conversation

sgherdao
Copy link
Contributor

  • use client.all_labs() then for each lab lab.details()
  • optimzation: use lab_details dict instead of lab.attrs as much as possible since most are properties, some with cache invalidation mechanisms. (we still use lab.statistics needed to get interface info)
  • add details method to CachedLab
  • add new mock for GET /labs/{lab_id}

- use `client.all_labs()` then for each lab `lab.details()`
- optimzation: use `lab_details` dict instead of `lab.attrs` as much as
  possible since most are properties, some with cache invalidation
  mechanisms. (we still use `lab.statistics` needed to get interface info)
- add `details` method to CachedLab
- add new mock for `GET /labs/{lab_id}`
@sgherdao
Copy link
Contributor Author

#152

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9701711915

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 75.758%

Files with Coverage Reduction New Missed Lines %
virl/api/cml.py 3 86.67%
Totals Coverage Status
Change from base Build 9625913576: -0.08%
Covered Lines: 1950
Relevant Lines: 2574

💛 - Coveralls

@sgherdao
Copy link
Contributor Author

I can probably remove some stuff from CachedLab, to get back those 0.08 % :)

@sgherdao
Copy link
Contributor Author

sgherdao commented Jul 5, 2024

closing that one

@sgherdao sgherdao closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants