Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equality operator for entity #432

Merged
2 commits merged into from Mar 31, 2017
Merged

Add equality operator for entity #432

2 commits merged into from Mar 31, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 31, 2017

  • Validate entity for edit operations (crud & netconf service)
  • Make Entity::get_children() a const method

* Validate entity for edit operations (crud & netconf service)
@ghost ghost added the in progress label Mar 31, 2017
@codecov-io
Copy link

Codecov Report

Merging #432 into master will decrease coverage by 1.69%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #432     +/-   ##
=========================================
- Coverage   85.03%   83.33%   -1.7%     
=========================================
  Files          99      101      +2     
  Lines       11588    13371   +1783     
  Branches     1674     2010    +336     
=========================================
+ Hits         9854    11143   +1289     
- Misses       1277     1650    +373     
- Partials      457      578    +121
Impacted Files Coverage Δ
ydkgen/printer/cpp/class_constructor_printer.py 97.4% <ø> (-0.04%) ⬇️
ydkgen/printer/cpp/class_get_children_printer.py 100% <100%> (ø) ⬆️
ydkgen/printer/cpp/class_members_printer.py 96.12% <100%> (ø) ⬆️
ydkgen/printer/cpp/class_get_child_printer.py 100% <100%> (ø) ⬆️
...dkgen/printer/cpp/class_get_entity_path_printer.py 96.35% <100%> (ø) ⬆️
ydkgen/printer/cpp/class_source_printer.py 97.97% <50%> (-0.99%) ⬇️
ydkgen/builder/test_case/test_cases_builder.py 77.69% <0%> (-3.24%) ⬇️
ydkgen/builder/test_case/test_value_builder.py 90.37% <0%> (-1.68%) ⬇️
...dk/python/core/ydk/services/_meta/_ietf_netconf.py 100% <0%> (ø) ⬆️
ydkgen/printer/cpp/class_has_data_printer.py 100% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c47c7e...8514b9b. Read the comment docs.

@ghost ghost merged commit 16f19e6 into CiscoDevNet:master Mar 31, 2017
@ghost ghost deleted the equality branch March 31, 2017 21:13
@ghost ghost removed the in progress label Mar 31, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant