-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub issues rebase #679
GitHub issues rebase #679
Conversation
ylil93
commented
Feb 5, 2018
- repackaged go errors separately from types
- anyxml in path api (Path API should accept XML declaration in anyxml data nodes #662)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks @ylil93. Just had couple of minor suggestions.
@@ -114,11 +114,25 @@ ydk::path::DataNodeImpl::populate_new_schemas_from_path(const std::string& path) | |||
ydk::path::DataNode& | |||
ydk::path::DataNodeImpl::create_datanode(const std::string& path, const std::string& value) | |||
{ | |||
std::string v = value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest moving lines 117-129 into a separate function called something like 'escape_xml_declaration()
'. This is so that it is clear what is being done by these lines of code.
@@ -128,6 +128,21 @@ def test_get_schema(self): | |||
xml = self.codec.encode(res, EncodingFormat.XML, False) | |||
self.assertNotEqual( len(xml), 0 ) | |||
|
|||
def test_anyxml(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add a testcase in test_sanity_codec.py ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did...
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 74.17% 74.22% +0.04%
==========================================
Files 104 104
Lines 10453 10470 +17
Branches 1467 1467
==========================================
+ Hits 7754 7771 +17
Misses 2397 2397
Partials 302 302
Continue to review full report at Codecov.
|
ff7dba4
to
1ec2c5b
Compare
Thanks @ylil93 for this change! |