GitHub issues rebase #679
Merged
GitHub issues rebase #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ylil93
commented
Feb 5, 2018
ylil93
commented
- repackaged go errors separately from types
- anyxml in path api (Path API should accept XML declaration in anyxml data nodes #662)
ghost
suggested changes
Feb 5, 2018
| @@ -114,11 +114,25 @@ ydk::path::DataNodeImpl::populate_new_schemas_from_path(const std::string& path) | |||
| ydk::path::DataNode& | |||
| ydk::path::DataNodeImpl::create_datanode(const std::string& path, const std::string& value) | |||
| { | |||
| std::string v = value; | |||
There was a problem hiding this comment.
Suggest moving lines 117-129 into a separate function called something like 'escape_xml_declaration()'. This is so that it is clear what is being done by these lines of code.
| @@ -128,6 +128,21 @@ def test_get_schema(self): | |||
| xml = self.codec.encode(res, EncodingFormat.XML, False) | |||
| self.assertNotEqual( len(xml), 0 ) | |||
|
|
|||
| def test_anyxml(self): | |||
There was a problem hiding this comment.
Could you please also add a testcase in test_sanity_codec.py ?
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 74.17% 74.22% +0.04%
==========================================
Files 104 104
Lines 10453 10470 +17
Branches 1467 1467
==========================================
+ Hits 7754 7771 +17
Misses 2397 2397
Partials 302 302
Continue to review full report at Codecov.
|
ylil93
force-pushed
the
github_issues_rebase
branch
from
ff7dba4
to
1ec2c5b
Compare
ghost
approved these changes
Feb 6, 2018
ghost
merged commit 
|
Thanks @ylil93 for this change! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.