-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Golang package reduction merge #723
Conversation
…delsLocation() out of Entity interface
- remove unnecessary util functions - renamed GetCommonEntityData() to GetEntityData() - refactored GetChildren() out of Entity interface
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 80.16% 80.46% +0.29%
==========================================
Files 173 170 -3
Lines 16451 16268 -183
Branches 1481 1470 -11
==========================================
- Hits 13188 13090 -98
+ Misses 2906 2820 -86
- Partials 357 358 +1
Continue to review full report at Codecov.
|
fp = FunctionPrinter(self.ctx, clazz) | ||
rstmt = '"%s"' % clazz.owner.stmt.arg | ||
fp.quick_print('GetParentYangName', return_type='string', return_stmt=rstmt) | ||
@staticmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why this should be a staticmethod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a codacy suggested style change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ylil93 for this change!
No description provided.