Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang package reduction merge #723

Merged
17 commits merged into from
Mar 26, 2018
Merged

Golang package reduction merge #723

17 commits merged into from
Mar 26, 2018

Conversation

ylil93
Copy link
Contributor

@ylil93 ylil93 commented Mar 25, 2018

No description provided.

@ylil93
add CommonEntityData struct, refactor GetYangName() func out of Entit…
e5affde 
…y interface
@ylil93
refactor GetBundleName() func out of Entity interface
4f70faf
@ylil93
refactor GetParentYangName() out of Entity interface
748744a
@ylil93
refactor GetLeafs() out of Entity interface
529e71b
@ylil93
refactor Get/SetParent() out of Entity interface
b06eafc
@ylil93
refactor GetFilter() out of Entity interface
c672782
@ylil93
refactor GetChildByName() out of Entity interface
629ec40
@ylil93
refactor GetCapabilitiesTable(), GetNamespaceTable(), GetBundleYangMo…
12d0545 
…delsLocation() out of Entity interface
@ylil93
travis test
d4a3689
@ylil93
refactor CreateNewChild() out of Entity interface
1521700
@ylil93
refactor GetSegmentPath() out of Entity interface
fe44861
@ylil93
refactor GetGoName() out of Entity interface
75d86a2
@ylil93
added utility functions for GetParent() and SetParent()
9767eaa
@ylil93
clean up CommonEntityData
e7c5f79 
- remove unnecessary util functions
- renamed GetCommonEntityData() to GetEntityData()
- refactored GetChildren() out of Entity interface
@ylil93
clean up
16b9b4b 
- update documentation
- rename LeafStore to YLeaf to be consistent with py/cpp
- rename ChildStore to YChild to be consistent with py/cpp
- added GetSegmentPath() util func
@ylil93
fix SegmentPath printer; update samples
f5a291b
@codecov
Copy link

codecov bot commented Mar 25, 2018 •
edited
Loading

Codecov Report

Merging #723 into master will increase coverage by 0.29%.
The diff coverage is 89.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   80.16%   80.46%   +0.29%     
==========================================
  Files         173      170       -3     
  Lines       16451    16268     -183     
  Branches     1481     1470      -11     
==========================================
- Hits        13188    13090      -98     
+ Misses       2906     2820      -86     
- Partials      357      358       +1
Impacted Files Coverage Δ
sdk/go/core/ydk/providers/providers.go 82.55% <100%> (ø) ⬆️
ydkgen/printer/go/class_constructor_printer.py 93.93% <100%> (ø) ⬆️
sdk/go/core/ydk/types/types.go 68.64% <83.82%> (+11.5%) ⬆️
sdk/go/core/ydk/path/path.go 91.02% <92.1%> (-0.06%) ⬇️
ydkgen/printer/go/class_printer.py 95.87% <94.44%> (-3.36%) ⬇️
ydkgen/printer/go/function_printer.py 78.12% <0%> (-18.75%) ⬇️
ydkgen/printer/printer_context.py 83.33% <0%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfffeb...f2ea0f7. Read the comment docs.

ghost
ghost reviewed Mar 26, 2018
View reviewed changes
ydkgen/printer/go/class_printer.py
fp = FunctionPrinter(self.ctx, clazz)
rstmt = '"%s"' % clazz.owner.stmt.arg
fp.quick_print('GetParentYangName', return_type='string', return_stmt=rstmt)
@staticmethod
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why this should be a staticmethod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a codacy suggested style change

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense

ghost
ghost approved these changes Mar 26, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ylil93 for this change!

@ghost ghost merged commit c9b8708 into CiscoDevNet:master Mar 26, 2018
@ylil93 ylil93 deleted the golang_merge branch April 5, 2018 19:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ylil93