Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTL wait=0 bug #1673

Merged
merged 4 commits into from
Oct 12, 2022
Merged

TTL wait=0 bug #1673

merged 4 commits into from
Oct 12, 2022

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Oct 10, 2022 •
edited
Loading

TMPE.zip
fixes #1497 see issue

Test

created a setup like this video https://youtu.be/EqkzznhV6hc?t=760
result:

  • prev code: step3 did not wait for pedestrians to pass
  • fixed code: step3 properly waits for pedestrian to pass

side effects

the fix is guarded by ChangeMetric != StepChangeMetric.NoWait so it has not effect on other change metrics.

@kianzarrin
TTL log slider
54f5e90 
hide slider when redundant
reorder criteria by importance.
@kianzarrin
60650cd
@kianzarrin
fixed wait=0 bug
b693967
@kianzarrin kianzarrin added BUG Defect detected TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc labels Oct 10, 2022
@kianzarrin kianzarrin self-assigned this Oct 10, 2022
@kianzarrin kianzarrin changed the base branch from master to TTL-UI-redundancy October 10, 2022 18:44
@krzychu124 krzychu124 added this to the 11.8.0 milestone Oct 10, 2022
chameleon-tbn
chameleon-tbn approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Base automatically changed from TTL-UI-redundancy to master October 12, 2022 13:40
@kianzarrin kianzarrin merged commit 5ea096b into master Oct 12, 2022
@kianzarrin kianzarrin deleted the TTL-wait-bug branch October 12, 2022 14:07
@krzychu124 krzychu124 modified the milestones: 11.8.0, 11.7.2.0 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

Assignees

@kianzarrin kianzarrin

Labels
BUG Defect detected TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc
Projects
None yet
Milestone
11.7.2.0
Development

Successfully merging this pull request may close these issues.

Timed-traffic light step switch condition wait = 0 always evaluating as True
3 participants
@kianzarrin @krzychu124 @chameleon-tbn