-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo truck transfer pathfinding fixes #1703
Merged
krzychu124
merged 7 commits into
master
from
bugfix/1701-cargo-truck-transfer-mixed-path-issues
Dec 13, 2022
Merged
Cargo truck transfer pathfinding fixes #1703
krzychu124
merged 7 commits into
master
from
bugfix/1701-cargo-truck-transfer-mixed-path-issues
Dec 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple types of cargo transport (train/plane/ship) but also lane routing via CargoVehicle lanes which solves issues for buildings that suppose to allow for pass through vehicle paths
krzychu124
added
BUG
Defect detected
confirmed
Represents confirmed issue or bug
STABLE
TM:PE STABLE branch
LANE ROUTING
Feature: Lane arrows / connectors
VEHICLE RESTRICTIONS
Feature: Vehicle restrictions
PATHFINDER
Pathfinding tweaks or issues
TEST
TEST version of the mod / workshop page
labels
Nov 29, 2022
kianzarrin
reviewed
Nov 29, 2022
do we need to deal with Cargo Vehicle in public static LaneEndTransitionGroup GetLaneEndTransitionGroup(VehicleInfo.VehicleType vehicleType) {
LaneEndTransitionGroup ret = 0;
if (vehicleType.IsFlagSet(ROAD_VEHICLE_TYPES))
ret |= LaneEndTransitionGroup.Road;
if (vehicleType.IsFlagSet(TRACK_VEHICLE_TYPES))
ret |= LaneEndTransitionGroup.Track;
return ret;
}
public static LaneEndTransitionGroup GetLaneEndTransitionGroup(this NetInfo.Lane laneInfo) {
LaneEndTransitionGroup ret = 0;
if(laneInfo.MatchesRoad())
ret |= LaneEndTransitionGroup.Road;
if (laneInfo.MatchesTrack())
ret |= LaneEndTransitionGroup.Track;
return ret;
} |
kianzarrin
reviewed
Dec 5, 2022
kianzarrin
reviewed
Dec 5, 2022
kianzarrin
reviewed
Dec 5, 2022
kianzarrin
reviewed
Dec 6, 2022
kianzarrin
reviewed
Dec 6, 2022
Co-authored-by: kianzarrin <[email protected]>
….g.: for Cargo Truck transfers
Merged
kianzarrin
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for the minor readability issue LGTM
kvakvs
approved these changes
Dec 12, 2022
krzychu124
deleted the
bugfix/1701-cargo-truck-transfer-mixed-path-issues
branch
December 13, 2022 08:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BUG
Defect detected
confirmed
Represents confirmed issue or bug
LANE ROUTING
Feature: Lane arrows / connectors
PATHFINDER
Pathfinding tweaks or issues
STABLE
TM:PE STABLE branch
TEST
TEST version of the mod / workshop page
VEHICLE RESTRICTIONS
Feature: Vehicle restrictions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1701
CargoVehicle
lanes which solves issues for buildings that suppose to allow for pass through vehicle paths like cargo terminals but also Airports DLC dual track Cargo Train StationNote
I've swapped method for matching lanes for
RoutingManager
, because the original was already used by lane connection tool (and more) and I didn't want to increase complexity or scope of tests.Additionally lanes with
CargoVehicles
are not available for configuration in game by any tools we support and at this state they are used internally only in form of invisible paths included in building assets and meant to be used as internal paths with certain limitations.More info about the problem and small test savegame you can find in the mentioned issue.
Build ZIP