Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after savegame data loading may lead to incomplete data for setting lane arrows #1747

Merged
merged 1 commit into from
May 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion TLM/TLM/State/Flags.cs
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,15 @@ public static bool ResetLaneArrowFlags(uint laneId) {
#if DEBUGFLAGS
Log._Debug($"Flags.resetLaneArrowFlags: Resetting lane arrows of lane {laneId}.");
#endif
if (LaneConnectionManager.Instance.Road.HasOutgoingConnections(laneId)) {
bool? hasOutgoingConnections = null;
try {
hasOutgoingConnections = LaneConnectionManager.Instance.Road.HasOutgoingConnections(laneId);
} catch (Exception _) {
// temporary solution, HasOutgoingConnections may throw exception if some flag is incorrect
// It does not affect what it was, since we are performing action only on success
}

if (hasOutgoingConnections.HasValue && hasOutgoingConnections.Value) {
LaneArrows? arrows = LaneConnectionManager.Instance.Road.GetArrowsForOutgoingConnections(laneId);
#if DEBUGFLAGS
Log._Debug($"Flags.resetLaneArrowFlags: Lane {laneId} has outgoing connections. Calculated Arrows: {(arrows.HasValue ? arrows.Value : "<none>")}");
Expand Down