Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIED-137 | Add instructions for using local tunnistamo instance #367

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

charn
Copy link
Contributor

@charn charn commented Nov 10, 2023

  • Add instructions for setting up the local Tunnistamo instance correctly
  • Add a fix to compose.yaml enabling the backend to fetch authentication configuration from locally running Tunnistamo instance

Without the default network locally running backend
is not able to access a locally running Tunnistamo
instance and fetch its configuration.

Refs: TIED-137
@charn charn requested a review from a team November 10, 2023 12:23
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #367 (9853a43) into main (a189deb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         104      104           
  Lines        5021     5021           
=======================================
  Hits         4798     4798           
  Misses        223      223           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charn charn merged commit 9d9d7ce into main Nov 16, 2023
4 checks passed
@charn charn deleted the TIED-137-local-tunnistamo branch November 16, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants