Copy hearing #363
Merged
Copy hearing #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hienous
approved these changes
Dec 14, 2021
danipran
added a commit
that referenced
this pull request
Apr 26, 2024
Some of the serializers worked with a update-or-copy logic instead of update-or-create (as their name would imply), which was added in PR #363 (6c97234). This caused an error whenever you're creating a new hearing and have already uploaded a file to a section (via the form's file upload functionality). Added a test to confirm that this scenario functions correctly now. This removes that copy logic and moves the burden to the consumer of the API, i.e. the consumer needs to remove the IDs from the data they want to copy.
danipran
added a commit
that referenced
this pull request
May 3, 2024
Some of the serializers worked with a update-or-copy logic instead of update-or-create (as their name would imply), which was added in PR #363 (6c97234). This caused an error whenever you're creating a new hearing and have already uploaded a file to a section (via the form's file upload functionality). Added a test to confirm that this scenario functions correctly now. This removes that copy (or rather, save as copy) logic and moves the burden to the consumer of the API, i.e. the consumer needs to remove the IDs from the data they want to copy. However, files and images still need a reference to the instance they're copied from, so add a new field "reference_id" for this. This allows the user to create new files or images based on existing instances. In its current state, it's meant for "save as new" type of situations. This means that if the pk is set for an image/file, then it will ignore the reference_id, i.e. you cannot update an existing instance using reference_id.
danipran
added a commit
that referenced
this pull request
May 6, 2024
Some of the serializers worked with a update-or-copy logic instead of update-or-create (as their name would imply), which was added in PR #363 (6c97234). This caused an error whenever you're creating a new hearing and have already uploaded a file to a section (via the form's file upload functionality). Added a test to confirm that this scenario functions correctly now. This removes that copy (or rather, save as copy) logic and moves the burden to the consumer of the API, i.e. the consumer needs to remove the IDs from the data they want to copy. However, files and images still need a reference to the instance they're copied from, so add a new field "reference_id" for this. This allows the user to create new files or images based on existing instances. In its current state, it's meant for "save as new" type of situations. This means that if the pk is set for an image/file, then it will ignore the reference_id, i.e. you cannot update an existing instance using reference_id.
danipran
added a commit
that referenced
this pull request
May 7, 2024
Some of the serializers worked with a update-or-copy logic instead of update-or-create (as their name would imply), which was added in PR #363 (6c97234). This caused an error whenever you're creating a new hearing and have already uploaded a file to a section (via the form's file upload functionality). Added a test to confirm that this scenario functions correctly now. This removes that copy (or rather, save as copy) logic and moves the burden to the consumer of the API, i.e. the consumer needs to remove the IDs from the data they want to copy. However, files and images still need a reference to the instance they're copied from, so add a new field "reference_id" for this. This allows the user to create new files or images based on existing instances. In its current state, it's meant for "save as new" type of situations. This means that if the pk is set for an image/file, then it will ignore the reference_id, i.e. you cannot update an existing instance using reference_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs. KER-21