-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1348/partners listing search #1407
Conversation
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sites/partners/pages/index.tsx
Outdated
import Head from "next/head" | ||
import { | ||
PageHeader, | ||
// NavigationHeader, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
Good Catches @emilyjablonski! Those issues should be resolved now. Also, noticing that the centering issue is present in core as well so I can make those component updates once this PR is finalized. |
Pull Request Template
Issue Overview
This PR addresses #1348
Description
This re-implements search on Detroit Partner's and refactoring it to utilize the new AG table and AG Pagination components.
How Can This Be Tested/Reviewed?
This PR can be tested by going to Detroit Partners, logging in, and typing in the search bar (at least 3 characters). The listings should automatically filter to match that string. Additionally, test all other existing partners table features. This includes sorting by column, ordering the columns, and logging out and logging back in to see your most recent table configuration.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.