Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1348/partners listing search #1407

Merged
merged 12 commits into from
Aug 9, 2022
Merged

1348/partners listing search #1407

merged 12 commits into from
Aug 9, 2022

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Jul 26, 2022

Pull Request Template

Issue Overview

This PR addresses #1348

  • This change addresses the issue in full

Description

This re-implements search on Detroit Partner's and refactoring it to utilize the new AG table and AG Pagination components.

How Can This Be Tested/Reviewed?

This PR can be tested by going to Detroit Partners, logging in, and typing in the search bar (at least 3 characters). The listings should automatically filter to match that string. Additionally, test all other existing partners table features. This includes sorting by column, ordering the columns, and logging out and logging back in to see your most recent table configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit d17c975
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/62e17bbb3bb4b90008967c1a
😎 Deploy Preview https://deploy-preview-1407--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit d17c975
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/62e17bbbcb92ff0008a14cc3
😎 Deploy Preview https://deploy-preview-1407--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for detroit-storybook-dev ready!

Name Link
🔨 Latest commit d17c975
🔍 Latest deploy log https://app.netlify.com/sites/detroit-storybook-dev/deploys/62e17bbb7bb5e70008e6413c
😎 Deploy Preview https://deploy-preview-1407--detroit-storybook-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-07-27 at 9 28 49 AM
This is looking great, just one small fix on alignment of the helper text box on desktop

import Head from "next/head"
import {
PageHeader,
// NavigationHeader,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@ColinBuyck
Copy link
Collaborator Author

Good Catches @emilyjablonski! Those issues should be resolved now. Also, noticing that the centering issue is present in core as well so I can make those component updates once this PR is finalized.

@ColinBuyck ColinBuyck merged commit 000fa07 into dev Aug 9, 2022
@ColinBuyck ColinBuyck deleted the 1348/partners-listing-search branch August 9, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants