fix: updated homepage spacing #1414
Conversation
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sites/public/styles/footers.scss
Outdated
| @@ -4,8 +4,9 @@ footer.site-footer > .footer-row:first-of-type { | |||
| } | |||
|
|
|||
| .footer-sections { | |||
| padding: 2rem 0; | |||
| max-width: 1024px; | |||
| @apply py-8; | |||
There was a problem hiding this comment.
We're moving off of tailwind, do you mind adding these as vanilla css classes since they're new?
There was a problem hiding this comment.
@emilyjablonski Just updated!
There was a problem hiding this comment.
@emilyjablonski We should talk about this. I don't know if vanilla CSS is the solution here. I think what we want is to create tokens using CSS variables so we can reuse this spacers across the site.
There was a problem hiding this comment.
I believe the tokens are available already…just need to swap out any remaining @apply or hardcoded values (aka var(--bloom-s2) rather than 0.5rem)
Pull Request Template
Issue Overview
This PR addresses bloom-housing#2927
Description
This PR updates the spacing on the coming soon section, the regions section, and the footer.
How Can This Be Tested/Reviewed?
This can be tested by using the Public preview and verifying that the changes reflect those seen in the issue.
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.