Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issues found in QA #124

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fixes for issues found in QA #124

merged 3 commits into from
Sep 16, 2024

Conversation

cbhernan
Copy link
Collaborator

What does this PR do?

  • Update angeleno site urls to new sandbox urls
  • Allow text to be highlighted in MFA TOTP modal
  • Update copyright date
  • Fixed unable to disable immediately after enabling Unable to unenroll MFA immediately after enrolling #123
  • Fixed scrollbar over text inputs and edit button on Profile page
  • Fixed error showing prior to user interaction. Disabled continue option until fields have values.

Which issue(s) is/are related to this PR?

Closes #123

- Update angeleno site urls to new sandbox urls
- Allow text to be highlighted in MFA TOTP modal
- Update copyright date
- Fixed unable to disable immediately after enabling #123
- Fixed scrollbar over text inputs and edit button on Profile page
- Fixed error showing prior to user interaction. Disabled continue
  option until fields have values.
Copy link

github-actions bot commented Sep 16, 2024

Visit the preview URL for this PR (updated for commit 5fcaa3f):

https://angeleno-my-account-dev-402917--pr124-qa-updates-4ph329qz.web.app

(expires Mon, 23 Sep 2024 21:56:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ef7f92b444e46d3ebe3d59054b9a245afee849f5

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 91.97080% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (047d6fe) to head (5fcaa3f).
Report is 4 commits behind head on development.

Files with missing lines Patch % Lines
lib/views/screens/profile_screen.dart 93.82% 5 Missing ⚠️
lib/views/screens/home_screen.dart 40.00% 3 Missing ⚠️
lib/views/dialogs/mobile.dart 90.47% 2 Missing ⚠️
lib/controllers/auth0_user_api_implementation.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #124      +/-   ##
===============================================
+ Coverage        80.41%   80.59%   +0.17%     
===============================================
  Files               16       16              
  Lines             1001     1015      +14     
===============================================
+ Hits               805      818      +13     
- Misses             196      197       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbhernan cbhernan merged commit c574da6 into development Sep 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to unenroll MFA immediately after enrolling
2 participants