-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Password Validation #4
Conversation
Hey @cbhernan , can you try the following code?
I noticed you are using variables to determine if the password is visible or not. I think it can all be added to the widget itself instead of the class. https://www.geeksforgeeks.org/flutter-show-hide-password-in-textfield/ I agree with the validator, we should try to make it into a function. Also, let's remove import 'package:flutter/cupertino.dart'; since that is iOS specific. |
@Paz-X Thank you for finding the correct icons, I've replaced them and removed the Cupertino icons. You're right that I could just use the variable instead of using a ternary for The validator is currently a function, it's called Regarding your suggestion, do you want me to replace what's currently on the branch with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR consolidates the Password field validations to use a single function to validate input. It also adds the icons to the password fields so that the user can toggle between password and text view on their input. It also enables the Change Password button to be enabled once all fields are filled.
Issue
#3