Reuse Tokens & Misc. Changes #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #97 +/- ##
===============================================
- Coverage 81.59% 81.14% -0.46%
===============================================
Files 15 15
Lines 864 907 +43
===============================================
+ Hits 705 736 +31
- Misses 159 171 +12 ☔ View full report in Codecov by Sentry. |
- Autofocus and Enforce Phone Validation in non-test mode - Introduce a variable to determine if running flutter test - Dialog return values as ints, instead of type conversion - Implement full screen dialog on mobile view - Change phone number input country code to bottom sheet to prevent loading all flags on widget mount. Also had issues on mobile.
Increases the contrast for disabled inputs from 1.2:1 to 4.25:1, recommended contrast is 3:1 to meet accessibility standards
|
Visit the preview URL for this PR (updated for commit 4ee5cbe): https://angeleno-my-account-dev-402917--pr97-ghi63-reuse-token-fm8dh8wy.web.app (expires Thu, 11 Apr 2024 22:28:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ef7f92b444e46d3ebe3d59054b9a245afee849f5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The main changes in this PR is the reusing of a token as long as it has not expired.
Minor changes:
Background info:
We were creating new tokens on every request
Which issue(s) is/are related to this PR?
This PR is/are related to issue(s)
Closes #63