-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor the src code & add initial ci tests #7
Conversation
➿ Code coverage
|
@jaylenw , noting that there is a deprecation warning in https://github.com/CityOfLosAngeles/fetch-latest-github-release/actions/runs/4994953857. |
Ah yes, I forgot to mention this. I will create an issue for us to explore https://github.com/ArtiomTr/jest-coverage-report-action as it has recent activity suggesting it is maintained. The action I added looks like it is no longer being supported based off of the lack of recent activity. I will create an issue for this and merge this PR for now. Thanks! |
Noting @RV-LACity Issue created, #8. |
What does this PR do?
The PR makes substantial changes to the src code to resolve the deprecation notices mentioned here https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ and here https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
I expect no API breaking changes. I added testing with Jest and Nock, as well as modified the example GitHub Action Workflows to make sure everything was up to date and all was well. A new GitHub Action workflow has been added to provide coverage reports in PRs.
Documentation has been updated appropriately.
Background info
Resources referenced:
GITHUB_OUTPUT
environment file. The tests explains a lot on how it was done).INPUT_{variable-name}
available in the system to retrieve it ascore.getInput('{variable-name}')
, see.jest/setEnvVars.js
The
node_modules
folder has to be committed as documented by GitHub. I have rannpm audit fix
to resolve any security vulnerabilities npm found.You may view the successful workflow runs here https://github.com/CityOfLosAngeles/fetch-latest-github-release/actions/runs/4994739002.
How can this be tested (manually and/or automated test)?
Provide Manual tests Steps if applicable
N/A
Provide steps for running automated tests if applicable
npm test
Code coverage report is provided in
coverage/
.Which issue(s) is/are related to this PR?
This PR is/are related to issue(s) #6
close #6