629 organize the daily wys dag #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 20, 2024
…ityofToronto/bdit_data-sources into 629-organize-the-daily-wys-dag
chmnata
requested changes
Aug 23, 2024
wys/api/README.md
Outdated
|
|
||
| ## `api_main` Process | ||
|
|
||
| The main function in the puller script `api_main` performs the following steps: | ||
|
|
||
| 1. Parse the `config.cfg` file (for API key and database credentials) and any input parameters. | ||
| 2. Retrieve the list of all signs from the `signs` endpoint by calling `location_id()` function, if `location_flag` is `0`. Insert/update into `wys.locations` using `wys.daily_intersections` as a staging table to identify new and updated signs. | ||
| 1. Retrive API key and database credentials from Airflow variables (must be run in `airflow_venv`. |
There was a problem hiding this comment.
retrieve typo and a missing )
wys/api/python/wys_api.py
Outdated
| DELETE FROM wys.raw_data | ||
| WHERE datetime_bin >= {}::timestamp AND datetime_bin < {}::timestamp + interval '1 day'; | ||
| """) | ||
| delete_sql = delete_sql.format(sql.Literal(str(start_date)), sql.Literal(str(start_date))) |
There was a problem hiding this comment.
I think we should try not to use sql.Literal as much as we can and use %s as the placeholder instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
signsinstead ofstatistics)wys.aggregate_speed_counts_one_hour_5kphfailing with duplicate key error #720)pull_wystask into 4 parts:get_signs,pull_wys(pull data for each sign),update_wys_locations,agg_speed_counts_hrread_google_sheets(see testing in#airflow_pipelines-dev). (Simplify the custom Slack message for WYS pull #715)Issue(s) this solves:
wys.aggregate_speed_counts_one_hour_5kphfailing with duplicate key error #720, Improve response handling from WYS API #816What, in particular, needs to reviewed:
wys_api.py: the changes are pretty significant so may want to review without looking at diff.What needs to be done by a sysadmin after this PR is merged