#1045 Remove limited lookback window on Ecocounter outages alert #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielwol
changed the title
gabrielwol
commented
Aug 28, 2024
| last_active | ||
| FROM ecocounter.sites | ||
| WHERE | ||
| last_active < CURRENT_DATE - 1 |
There was a problem hiding this comment.
I changed to CURRENT_DATE - 1 (recommended by postgres docs 👀) instead of basing it off of ds, because this way it will be more accurate if task is rerun on a different date.
…-outage-notification
gabrielwol
deleted the
1045-remove-lookback-limit-from-ecocounter-outage-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
last_activecolumns and remove lookback limit.Issue(s) this solves:
What, in particular, needs to reviewed:
Nothing, see successful test in #airflow_pipelines-dev!
What needs to be done by a sysadmin after this PR is merged
Pull into data_scripts