Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1067 #1066 Update instructions for adding a new spreadsheet #1069

Merged

Conversation

radumas
Copy link
Member

@radumas radumas commented Sep 9, 2024

What this pull request accomplishes:

  • Updates README to better explain
    • what permissions need to be granted on sheet?
    • correct email / service account?
  • Also reorganized the flow of the README to deemphasize local development

Issue(s) this solves:

What, in particular, needs to reviewed:

  • Did I hit the right points

What needs to be done by a sysadmin after this PR is merged

Documentation only

@radumas radumas linked an issue Sep 9, 2024 that may be closed by this pull request
@gabrielwol gabrielwol added Vision Zero Data sources supporting VisionZero Documentation labels Sep 10, 2024
Copy link
Collaborator

@gabrielwol gabrielwol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One small change re: email.


### 4.2 Request sharing permission to the new sheet

The sheet must be shared with `[email protected]`. This ought to be View-only.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify where this email was found? (google service account).

@gabrielwol gabrielwol merged commit bad3d47 into master Oct 10, 2024
4 checks passed
@gabrielwol gabrielwol deleted the 1067-update-vz_google_sheets-readme-for-adding-a-new-year branch October 10, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Vision Zero Data sources supporting VisionZero
Projects
None yet
2 participants