-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I0617 rescu sensors eval #626
Conversation
can you rename the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Mostly formatting changes on volumes/rescu/rescu_sensors_eval_readme.md
and the recommendation to split up the content.
I haven't super wrapped my head around how this PR interacts with Sarah's we can try to merge that one first? And then I might have further specific suggestions about where things go in documentation land.
--this query can be used to identify detectors for repair requests. | ||
--recommend opening in qgis and styling based on 'classify'. Look for geographical gaps with bad/inactive sensors. | ||
--designate a set of `time_bins` (ie. current year) to get exact % active bins | ||
--includes inactive sensors that don't have any records during the designated `time_bins` | ||
--runs in 20s for 2023-01--2023-05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could this be a mat view in the rescu
schema, change the end dates to be now() plus some manipulation to include the last pulled date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orrrrrrrrrr... it could be a function that returns a SET/Table, with inputs of start and end date. I don't think this is necessary to implement rn, but a thought.
…dit_data-sources into i0617_rescu_sensors_eval
So we're going to revisit this and find the work a new home within the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this gwolofs
!
I found one smol typo in the readme (see inline comments) and there are some outstanding fluffs.
Organizationally speaking:
- on
bigdata
- these detector mat views are too good to be hidden ingwolofs
- have they been moved somewhere more public? I snooped onbigdata.vds
but I did not see them there - are they somewhere else? Have they been superceded? - on
bdit_data-sources
- this work is saved to the rescu folder which is appropriate given the focus. Is there any desire to migrate these to the vds folder and purge the rescu folder?- If there is, I would just create a "rescu_checks" subfolder in vds and migrate your folder structure there (pending any @radumas objections).
- I also think it would be fine to leave the rescu folder as-is
Realize this wasn't introduced in this PR but the below bullets didn't render properly bdit_data-sources/volumes/vds/readme.md Lines 146 to 148 in 4045015
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQL looks good. Main issue is markdown tables don't render properly.
Given the deletion of the broken sensor identification work because it is superseded, I identified some links that are likely going to rot when this PR is merged and the branch is deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:meow_mage:
:party-porg:
stale review. Gabe has made substantial changes that make the requested changes irrelephant
What this pull request accomplishes:
SQL to identify network wide outages and individual sensor VDS outages.
Identify RESCU detectors to repair this year during annual repair blitz.Committing this outdated work tovds
schema is confusing and if committed torescu
it would never be seen again so I chose to delete it. We have a new dashboard being developed by Chris which identifies sensors to repair and supersedes this piece of the PR. I kept and documented the two views I developed which may be helpful for others.Issue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged
Nothing