Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I0669 aggregate volumes 15min mvt tries to insert duplicate values #674

Conversation

gabrielwol
Copy link
Collaborator

What this pull request accomplishes:

  • Adds new function miovision_api.aggregate_15_min_mvt_single_intersection to aggregate just a single intersection into volumes_15min_mvt.
  • Improvements to existing miovision_api.aggregate_15_min_mvt function

Issue(s) this solves:

What, in particular, needs to reviewed:

What needs to be done by a sysadmin after this PR is merged

  • Update definition of miovision_api.aggregate_15_min_mvt
  • Add new function miovision_api.aggregate_15_min_mvt_single_intersection

@gabrielwol gabrielwol linked an issue Aug 15, 2023 that may be closed by this pull request
…cate-values' of github.com:CityofToronto/bdit_data-sources into i0669-aggregate-volumes_15min_mvt-tries-to-insert-duplicate-values
@gabrielwol gabrielwol marked this pull request as ready for review August 15, 2023 17:33
Copy link
Member

@radumas radumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! All the SQL looks good, just a minor issue in cur.execute

@gabrielwol
Copy link
Collaborator Author

Ready for re-review!

@chmnata chmnata merged commit 34fddc0 into master Nov 13, 2023
5 checks passed
@chmnata chmnata deleted the i0669-aggregate-volumes_15min_mvt-tries-to-insert-duplicate-values branch November 13, 2023 14:03
@chmnata
Copy link
Collaborator

chmnata commented Nov 13, 2023

Changes applied on postgres + airflow

@gabrielwol gabrielwol self-assigned this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregate-volumes_15min_mvt tries to insert duplicate values
3 participants