Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually check whether holidays may impact a given query #136

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Actually check whether holidays may impact a given query #136

merged 7 commits into from
Jul 16, 2024

Conversation

Nate-Wessel
Copy link
Contributor

@Nate-Wessel Nate-Wessel commented Jul 16, 2024 •
edited
Loading

Closes #85

  • checks whether holidays are relevant and displays NA in output if not
  • hides holidays options if they wouldn't actually impact any of the queries
    • makes some stylistic changes to the panel to make hiding this easier, which I'd been thinking of making anyway

@Nate-Wessel Nate-Wessel self-assigned this Jul 16, 2024
@Nate-Wessel Nate-Wessel merged commit 46a4215 into deploy Jul 16, 2024
1 check passed
@Nate-Wessel Nate-Wessel deleted the holidays branch July 16, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nate-Wessel Nate-Wessel

Labels
back-end front-end new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable holiday option if no dates in range(s) include holidays
1 participant
@Nate-Wessel