Initial pr #1
Open
Initial pr #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdesaulniers
commented
Sep 22, 2021
|
@compnerd mentioned that https://github.com/compnerd/toolchain-infrastructure might also be of interest. |
nickdesaulniers
force-pushed
the
initial_pr
branch
from
9d8507b
to
c54fb2a
Compare
compnerd
reviewed
Sep 22, 2021
| --syslibdir=/usr/local/lib \ | ||
| --disable-static | ||
|
|
||
| make -j$(nproc) AR=llvm-ar RANLIB=llvm-ranlib |
There was a problem hiding this comment.
Suggested change
| make -j$(nproc) AR=llvm-ar RANLIB=llvm-ranlib | |
| make -j$(nproc) AR=${AR:-ar} RANLIB=${RANLIB:-ranlib} |
The user can specify AR=llvm-ar RANLIB=llvm-ranlib to select it.
also, I had libc++abi built, but upon wiping my build artifacts and rerunning fresh, that doesn't build anymore...
breaking the build of libcxxabi.
nickdesaulniers
force-pushed
the
initial_pr
branch
from
c54fb2a
to
6a08c94
Compare
nickdesaulniers
commented
Sep 22, 2021
compnerd
reviewed
Sep 22, 2021
MaskRay
reviewed
Sep 22, 2021
| cmake \ | ||
| -D CMAKE_BUILD_TYPE=Release \ | ||
| -D CMAKE_CXX_COMPILER=$CXX \ | ||
| -D CMAKE_CXX_COMPILER_TARGET=x86_64-unknown-linux-musl \ |
There was a problem hiding this comment.
Is CMAKE_CXX_COMPILER_TARGET needed? Does LLVM_DEFAULT_TARGET_TRIPLE help?
compnerd
reviewed
Sep 22, 2021
nickdesaulniers
force-pushed
the
initial_pr
branch
from
241a7ff
to
9c72741
Compare
nickdesaulniers
commented
Sep 22, 2021
|
I'm very interested in this, will take a brief look next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got stuck getting libc++ to build; also, libc++abi seems to have regressed. Generally poor quality code that's full of trash and not cleaned up. Thought it might be worth posting if anyone is interested in playing with it.
EDIT: fixed the libc++abi build.