Add extra quest frames #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatatsumuriPan
commented
Mar 2, 2024
KatatsumuriPan
commented
- Remove PresetTexture.QUEST_AUX_*.
- Add many extra icons for quest frame.
- Separate flip-"isMain" button and change-quest-frame button.
- Add the new gui to select a quest frame.
WaitingIdly
requested changes
Mar 20, 2024
| package betterquesting.api.enums; | ||
|
|
||
| public enum EnumFrameType { | ||
| DEFAULT, |
There was a problem hiding this comment.
i believe there should be an option to have no frame (EMPTY).
| DIAGONAL_STAR4, | ||
| PRICKLE, | ||
| GEAR, | ||
| GATE, |
There was a problem hiding this comment.
MAIN as a prop should be deprecated, and should be converted into this frame option
| import net.minecraft.client.gui.GuiScreen; | ||
|
|
||
| @SuppressWarnings("WeakerAccess") | ||
| public class GuiQuestFrameSelection extends GuiScreenCanvas implements IPEventListener, IVolatileScreen { |
There was a problem hiding this comment.
should be accessible from the NBT editor frame entry
| itemPreview = new PanelQuest(new GuiTransform(GuiAlign.TOP_LEFT, 0, 16, 36, 36, 0), 99, itemStack, frameType, questState, isMain); | ||
| cvLeft.addPanel(itemPreview); | ||
|
|
||
| EnumQuestState[] values = EnumQuestState.values(); |
There was a problem hiding this comment.
should include a note about what this is for (previewing state in different colors), feels a bit weird without any explanation
|
superseded by #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.