Optimize quest database search #108
Conversation
KatatsumuriPan
commented
Mar 10, 2024
KatatsumuriPan
commented
- Add loading icon. (using the same texture as refresh)
- Buffering "addPanel()" on quest database to optimize search. (addPanel is too slow...)
| public IGuiRect getScrollBounds() { | ||
| return this.scrollBounds; | ||
| } | ||
| public IGuiRect getScrollBounds() { return this.scrollBounds; } |
There was a problem hiding this comment.
the standard formatting appears to include a new line between {, }, and the statement, as it was before this change. since IDEA will automatically do this shortening, theres no real benefit to doing it manually. i think this part should be reverted
| @@ -99,7 +100,8 @@ public enum PresetIcon { | |||
| ICON_MENU("icon_menu"), | |||
|
|
|||
| ICON_PATREON("icon_patreon"), | |||
| ICON_TWITCH("icon_twitch"); | |||
| ICON_TWITCH("icon_twitch"), | |||
| ICON_LOADING("icon_refresh"); | |||
There was a problem hiding this comment.
this has to have a different name, as icon_refresh already exists and is used as the Reset Quest icon on the designer. this change causes it to be constantly rotating.
There was a problem hiding this comment.
theres a lot of whitespace changes here, which on my instance of IDEA gets nuked instantly. either we need to get the formatting unified and just hasnt been prior (wouldnt be too surprising), or you might need to poke your formatter so it doesnt generate a bunch of superfluous changes.
|
Closing in favour of #114. Thank you for all the work! |
