Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce default values of the quest file #109

Open
wants to merge 8 commits into
base: 1.12
Choose a base branch
from
Open

Reduce default values of the quest file #109

wants to merge 8 commits into from

Conversation

KatatsumuriPan
Copy link

@KatatsumuriPan KatatsumuriPan commented Mar 11, 2024 •
edited
Loading

To reduce the quest file size, omit default values.

  • Renamed NBTReplaceUtil -> NBTUtil
  • Added "reduce" flag parameter to writeToNBT()s to specify whether to reduce or not. (Don't reduce on nbt editor.)
  • Added IPropertyReducible to omit default values.

@KatatsumuriPan
Copy link
Author

I'll fix backward compatibility

@KatatsumuriPan KatatsumuriPan marked this pull request as draft March 12, 2024 17:07
@KatatsumuriPan KatatsumuriPan marked this pull request as ready for review March 13, 2024 08:12
@Rongmario
Copy link
Member

Please fix the merge conflict

Rongmario
Rongmario approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@Rongmario Rongmario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling this in after #115.

@WaitingIdly WaitingIdly mentioned this pull request Jul 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rongmario Rongmario Rongmario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KatatsumuriPan @Rongmario