Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add japanese lang file #96

Merged
merged 18 commits into from
Oct 7, 2024
Merged

add japanese lang file #96

merged 18 commits into from
Oct 7, 2024

Conversation

code-onigiri
Copy link

No description provided.

Copy link

@MrKono MrKono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考程度に

src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
Also includes modifications from https://github.com/MrKono
Copy link

@MrKono MrKono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主に文体の修正案です

src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
@KatatsumuriPan
Copy link

まだ全部見れてませんが、今のところ全体的に

  • 狩りかモブ狩りに統一
  • ですます態の統一
  • すべて→全て
  • 全てのプレイヤー→全プレイヤー
  • 〇〇を〇〇→〇〇の〇〇
    あたりが統一されるとより質が上がるかもしれないですね

Copy link

@KatatsumuriPan KatatsumuriPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一旦この辺で止めます

src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
Copy link

@KatatsumuriPan KatatsumuriPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

さらにレビューしてみました。
ゲーム内で未使用の翻訳については、一部レビューしてません。
この辺が直ればマージしても良いのではないでしょうか。

src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
src/main/resources/assets/betterquesting/lang/ja_jp.lang Outdated Show resolved Hide resolved
@tier940
Copy link

tier940 commented Jul 22, 2024

@code-omusubi
確認してほしいみたいな意見があったので、確認してみました。
現状分の翻訳は問題なさそうですが、最新branchと見比べると足りないキーが結構あるので(10行くらい)、WinMergeなどで差分確認が必要そうです。

@code-onigiri
Copy link
Author

@code-omusubi 確認してほしいみたいな意見があったので、確認してみました。 現状分の翻訳は問題なさそうですが、最新branchと見比べると足りないキーが結構あるので(10行くらい)、WinMergeなどで差分確認が必要そうです。

ありがとうございます、更新をして新たな翻訳を追加しました。
その部分も確認してくださると嬉しいです。

@Rongmario Rongmario merged commit 5c4a097 into CleanroomMC:1.12 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants