Add isEnabled to IScriptReloadable, clarifying some NPE errors #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forestry already had a similar system in place, but applied exclusively to its own compat and didn't provide any error logging.
Now individual registries can override the
isEnabledmethod to ensure the registry actually exists. Only applied this to Integrated Dynamics (resolving #125), Blood Magic (uses same internals), and Forestry (pre-existing).now, when loading into the world you will be presented with a much more helpful error message of "that registry is disabled" instead of just "Null Pointer Exception".
don't know what appends the
Possible solutions:line, which in this context provides incorrect information.