Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obeying Intellij's linter thingy #128

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Obeying Intellij's linter thingy #128

merged 7 commits into from
Feb 19, 2024

Conversation

WaitingIdly
Copy link
Collaborator

Make a few changes because IDEA told me to:

  • change size() == 0 and similar to isEmpty()
  • flip equals comparing variable and string literal
  • make enums == instead of equals
  • remove unused imports
  • fix some minor warnings
  • remove pointless no-arg super
  • suppress warnings for some javadocs referencing private classes

@brachy84 brachy84 merged commit 6b6e1d0 into CleanroomMC:master Feb 19, 2024
@WaitingIdly WaitingIdly deleted the minor-cleanup branch March 16, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84