Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Better With Mods compat #131

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

WaitingIdly
Copy link
Collaborator

what this PR adds:

  • compat with anvilCrafting, cauldron, crucible, kiln, millStone, saw, turntable, heat, hopper, and hopperFilters
  • anvilCrafting has all the abilities of a normal crafting table (recipeFunction and recipeAction), which i believe adds novel functionality
  • examples for the above
  • i18n keys for the above

CraftTweaker, through ModTweaker, has the following explicit compat with Better With Mods that is not added in this PR:

  • bellows, controlling how far specific items are blown by the Bellows block
  • pulleymanager, allows adding what blocks can be pulleys
  • buoyancy, controlling if specific items float or sink in water
  • hcfurnace, allows setting the time in ticks a given input smelting item takes (only active with the hardmode module enabled)
  • hcmovement, allows controlling how fast the player walks on specific blocks (only active with the hardmode module enabled)

these werent added because

  1. i got tired
  2. they already have java methods to set the value and the actual Map used to store the data is a public field
  3. they dont have much benefit for being reloadable

relevant classes for anyone who wants access to those, or me if i decide to implement compat

betterwithmods.common.registry.BellowsManager
betterwithmods.common.registry.PulleyStructureManager
betterwithmods.module.hardcore.world.HCBuoy
betterwithmods.module.hardcore.crafting.HCFurnace
betterwithmods.module.hardcore.needs.HCMovement

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Feb 26, 2024
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same stuff as the other prs

@brachy84 brachy84 merged commit 3385225 into CleanroomMC:master Mar 14, 2024
@WaitingIdly WaitingIdly deleted the betterwithmods branch March 15, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants