Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Draconicevolution energy core block compat #135

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Add Draconicevolution energy core block compat #135

merged 8 commits into from
Mar 25, 2024

Conversation

brachy84
Copy link
Member

@brachy84 brachy84 commented Mar 2, 2024

:)

@brachy84 brachy84 added the mod compat Relating to compatability with a mod or features of a mod label Mar 9, 2024
WaitingIdly
WaitingIdly approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@WaitingIdly WaitingIdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it reloads properly now, just have a few suggestions relating to code style/some text.

src/main/resources/assets/groovyscript/lang/en_us.lang Outdated Show resolved Hide resolved
...ain/java/com/cleanroommc/groovyscript/compat/mods/draconicevolution/helpers/BlockStates.java Outdated Show resolved Hide resolved
...ain/java/com/cleanroommc/groovyscript/compat/mods/draconicevolution/helpers/BlockStates.java Outdated Show resolved Hide resolved
...roommc/groovyscript/compat/mods/draconicevolution/helpers/BlockStateEnergyCoreStructure.java Show resolved Hide resolved
@IntegerLimit
Copy link
Contributor

Please add config.

brachy84 and others added 2 commits March 22, 2024 18:13
@brachy84 brachy84 merged commit 8c16c6a into master Mar 25, 2024
1 check passed
@brachy84 brachy84 deleted the compat/de-energycore branch March 25, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaitingIdly WaitingIdly WaitingIdly approved these changes

Assignees
No one assigned
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brachy84 @IntegerLimit @WaitingIdly