generated from CleanroomMC/TemplateDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache compiled scripts #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should preInit scripts be cached? how helpful is caching them?
anyways, ive tested in a few places, and havent gotten any errors related to this change. my comments are just about the part users are going to interact with (the command)
src/main/java/com/cleanroommc/groovyscript/command/GSCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/command/GSCommand.java
Outdated
Show resolved
Hide resolved
brachy84
added
enhancement
New feature or request
sandbox
For internal changes to the sandbox
labels
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allows compiled scripts to be cached between reloads and even restarts. This can speed up subsequent reloads significantly.
The Supersymmetry modpack has an average reload (just groovy not restart) time of 70s. With this pr its only 3 - 7s.
How it works
Groovy compiles scripts into java classes. Before it creates the clas we can obtain the class bytes with a mixin. The class bytes will be immediatly written to a file and out put to
cache/groovy/class.name.clz
.cache/
is also used by other mods..clz
is not a known file ending afaik. Its just class, but clazz and shorter. The class name, bytes, script path, last modified date and inner class names are saved to a map, which is written tocache/groovy/_index.json
.On restart the index is read. When a script is about to load we can simply check if it exists in the index and define a class with the bytes. When a script is deleted, the cache (and for all inner classes) is automatically deleted.
Additional Information
/grs deleteClassCache
command wich clears thecache/groovy/
path.version
property to the index file. This allows us to automatically delete cache in the future, in case we make changes to loading/saving caches wich are not backwards compatible.