Block file access outside instance dir #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
requested changes
Mar 21, 2024
src/main/java/com/cleanroommc/groovyscript/sandbox/security/SandboxSecurityManager.java
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/sandbox/security/SandboxSecurityManager.java
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/sandbox/GroovyScriptSandbox.java
Outdated
Show resolved
Hide resolved
brachy84
added
enhancement
Rongmario
requested changes
Mar 23, 2024
src/main/java/com/cleanroommc/groovyscript/sandbox/security/SandboxSecurityManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/sandbox/security/SandboxSecurityManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cleanroommc/groovyscript/sandbox/GroovyScriptSandbox.java
Show resolved
Hide resolved
Rongmario
approved these changes
Mar 24, 2024
| @@ -181,6 +192,7 @@ public <T> T runClosure(Closure<T> closure, Object... args) { | |||
| return new AtomicInteger(); | |||
| }).addAndGet(1); | |||
| } finally { | |||
| securityManager.uninstall(); | |||
There was a problem hiding this comment.
Should be fine for now, not sure if there are any drastic performance penalties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.