add Rustic compat #146
Merged
add Rustic compat #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
added
the
mod compat
brachy84
requested changes
Mar 28, 2024
src/main/java/com/cleanroommc/groovyscript/compat/mods/rustic/CrushingTub.java
Outdated
Show resolved
Hide resolved
brachy84
reviewed
Apr 6, 2024
Comment on lines
+103
to
+110
| if (!validate()) return null; | ||
| ICrushingTubRecipe recipe = null; | ||
| for (ItemStack itemStack : input.get(0).getMatchingStacks()) { | ||
| ICrushingTubRecipe recipe1 = new CrushingTubRecipe(fluidOutput.get(0), itemStack, byproduct); | ||
| ModSupport.RUSTIC.get().crushingTub.add(recipe1); | ||
| if (recipe == null) recipe = recipe1; | ||
| } | ||
| return recipe; |
There was a problem hiding this comment.
This is fine for now, but im thinking about returning a list of all added recipes. We have something like this in a few more places.
brachy84
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
ICondenserRecipeandIEvaporatingBasinRecipeclasses to allow additional customization of these recipes types.ExtendedEvaporatingBasinRecipeallows customizing the time taken.CondenserRecipeallows customizing fluid input, bottle slot item, and time taken.BrewingBarrel,CrushingTub,EvaporatingBasin, andCondenser(both basic and advanced) compat