Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorten dependencies and make it cleaner #154

Merged
merged 3 commits into from
Apr 6, 2024
Merged

shorten dependencies and make it cleaner #154

merged 3 commits into from
Apr 6, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • simply the dependencies file by converting most mods into a map
  • remove duplicate mods
  • halve line length
  • should make it so there are less merge conflicts and they are easier to resolve

brachy84
brachy84 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@brachy84 brachy84 added refactor Something is rewritten build-script Something in build scripts changed labels Apr 6, 2024
@brachy84 brachy84 merged commit c06d374 into CleanroomMC:master Apr 6, 2024
@WaitingIdly WaitingIdly deleted the easy-dependency branch April 7, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
build-script Something in build scripts changed refactor Something is rewritten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84